Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TaskSeq.forall and forallAsync #240

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Conversation

abelbraaksma
Copy link
Member

@abelbraaksma abelbraaksma commented Mar 16, 2024

Part of the push for good coverage of surface area functions, see #208 for an overview. This implements TaskSeq.forall, TaskSeq.forallAsync.

Each of these behave exactly like their Seq counterparts:

  • raises on null input

As before, the xml doc blibs have been taken from seq.fs and modified a bit for readability and applicability to TaskSeq.

The signatures are as follows:

static member forall: predicate: ('T -> bool) -> source: TaskSeq<'T> -> Task<bool>
static member forallAsync: predicate: ('T -> #Task<bool>) -> source: TaskSeq<'T> -> Task<bool>

TODO list:

  • implement TaskSeq.forall
  • Implement TaskSeq.forallAsync
  • unit tests

@abelbraaksma abelbraaksma force-pushed the implement-forall branch 2 times, most recently from 1deb2f8 to 30c751e Compare March 16, 2024 23:58
@abelbraaksma
Copy link
Member Author

Unit tests added, rebased, should be good to go now. This was the last PR related to the list in #208.

@abelbraaksma abelbraaksma self-assigned this Mar 17, 2024
@abelbraaksma abelbraaksma added topic: surface area Adds functions to the public surface area feature request New feature or enhancement request labels Mar 17, 2024
@abelbraaksma abelbraaksma merged commit 953f218 into main Mar 17, 2024
6 checks passed
@abelbraaksma abelbraaksma deleted the implement-forall branch March 17, 2024 00:33
@abelbraaksma abelbraaksma added this to the v0.4.0 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or enhancement request topic: surface area Adds functions to the public surface area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant